test(core): cover manual compaction cancellation - #45335
Closed
kitlangton wants to merge 2 commits into
Closed
Conversation
This was referenced Aug 26, 2026
kitlangton
force-pushed
the
manual-compaction
branch
from
August 28, 2026 03:01
d23a19d to
b0284d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Manual compaction must settle a delivered control even if interruption arrives before summary execution begins. It must also leave the inbox available for mutations while the model is running. Existing streaming-cancellation tests did not pin down these two cases.
What Changes
Add two runner regression tests using the existing fixture and TestLLM:
The tests use explicit gates and the test clock rather than wall-clock sleeps. The inbox test times out only its completion observer and always releases the summary gate.
Scope
The earlier production extraction has been removed. This is now test-only: one file, 81 added lines, no new helpers. Runner/Compaction ownership, interruption handling, interfaces, and existing fixtures are unchanged.
Verification
Local verification ran on macOS. Fresh CI is running for tests-only head
c476515eb1; the previous extraction revision's green CI is not claimed as verification of this head. Auto-merge remains disabled.